feat(diagnostics): add fail-closed editor decorations - #256
Draft
seonghobae wants to merge 23 commits into
Draft
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 18, 2026
opencode-agent
Bot
added
priority: medium
…ion' into feat/writing-diagnostics-decorations Signed-off-by: Seongho Bae <me@seonghobae.me>
Contributor
Author
|
#256 was restacked onto the current #254 head 36ce576. Exact head: d28caf9 Verification on that tree:
Checks are currently queued before runner assignment. @codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Signed-off-by: Seongho Bae <me@seonghobae.me>
…ion' into feat/writing-diagnostics-decorations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Stacked Task 3 implementation lane for PR #248's writing-diagnostics plan. This Draft targets
feat/writing-diagnostics-projection; #254, #249 and #248 remain explicit dependency roots.Current exact stack authority
feat/writing-diagnostics-projection@760021c053fca1eb14fe1a344f10ccbf2d484ed5;5844b4e3547746c912bece476d92d4847d8e4e3c;main@3b38ead2d00f44eb578d0689087b9293b3dabe1eunder release: reconcile Office and npm versions before next stable registry publication #118.The branch was synchronized non-destructively to the corrected exact Task 2 parent. Fresh comparison resolves merge base exactly to that parent, reports
behind_by=0, and leaves exactly the six Task 3 decoration paths. The parent ADR-quality gate repair is preserved. No force push or destructive rebase was used.Product boundary and TDD lineage
This lane renders only already-validated structural ranges. Decorations contain static Inkspan classes, visual priority and an opaque diagnostic identifier; they do not carry source text, title, explanation, replacement, category text, model output, executable markup or semantic ARIA authority.
The plugin installs diagnostics by monotonic generation, bounds decoration count/identifier size, invalidates the complete generation on every
docChanged, focuses only an identifier in the exact active generation, rejects hostile metadata without leaking private thrown values, and performs no semantic inference/model/provider/network/database/host-callback work.Exact-current-head evidence
Current exact head
5844b4e3547746c912bece476d92d4847d8e4e3chas no qualifying current-head PR workflow runs returned by the live workflow-run query yet. Predecessor focused decorations TDD evidence is historical only. Formal reviews/threads have not supplied qualifying current-head approval. Current-head CI/security/SAST/coverage/package/browser/accessibility evidence remains non-passing until freshly produced.Integration boundary
Keep this PR Draft and stacked. Dependency order remains #248 → #249 → #254 → #256. Temporary branch-specific TDD workflow material must not survive protected integration. Final readiness requires exact-current-head canonical gates, zero valid unresolved findings/contradictions, qualifying independent approval, and release-order authorization after #118. Do not self-approve, transfer predecessor evidence, weaken gates or bypass stack order.